Skip to content

Conversation

@vinckr
Copy link
Member

@vinckr vinckr commented May 28, 2025

No description provided.

Co-authored-by: PM <piotr.mscichowski@gmail.com>
@vinckr
Copy link
Member Author

vinckr commented May 28, 2025

test seems to fail bc of mcp-oauth-provider 🤔 i dont understand why its even being tested in the first place...

@vinckr vinckr requested a review from aeneasr May 28, 2025 13:24
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check with @hperl - the sync script will most likely break our monorepo setup. We may need to deprecate the sync script for all monorepo repositories and move to a different pipeline for those.

@hperl
Copy link

hperl commented May 30, 2025

Please check with @hperl - the sync script will most likely break our monorepo setup. We may need to deprecate the sync script for all monorepo repositories and move to a different pipeline for those.

Right now the READMEs are excluded from the Copybara sync from Cloud to OSS, so this will not break our monorepo approach. We can change this later, but there is no rush and nothing breaks right now.

@vinckr vinckr enabled auto-merge (squash) May 30, 2025 16:40
@vinckr
Copy link
Member Author

vinckr commented Jun 3, 2025

since the internal PR to exclude the other template files as well is merged (#8599) this can be merged @aeneasr

@vinckr vinckr requested a review from aeneasr June 3, 2025 15:14
@vinckr
Copy link
Member Author

vinckr commented Jun 4, 2025

superseeded by #235

@vinckr vinckr closed this Jun 4, 2025
auto-merge was automatically disabled June 4, 2025 07:40

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants